fix: repair completely overlapping trips in ENTD #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleaning logic for ENTD covered trips that are entirely contained in another trip along the chain of a person. Those trips (actually, there is only one in the whole data set) were deleted so far. However, this causes a problem when checking for the consistency of activity types along the chain later on. So far, we didn't notice this, because we never used the entire ENTD, but only filtered data sets for individual sets of departments. The problem is now fixed by squeezing the first trip to duration zero and setting departure time and arrival time to the departure time of the following trip.