fix: shuffling of primary location candidates #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vincent-leblond Sorry for yet another request, could you please check what impact this PR has on your flow plots? I would wait for a brief analysis from your side before merging this. |
|
We looked at the PR with Marie. In the flow analysis, there is not much difference. It make sense as our flow analysis is done on municipalities and IRIS. |
|
Yes, I agree. Even though you don't see a big impact, what I take from your message is that there is also no negative impact and no strange things are happening. So we can merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of creating a PR that fixes #237. Running now to see if it has any impact on the unit tests.