Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the master/slave phrasing #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bopopescu
Copy link

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

@hjwp
Copy link
Contributor

hjwp commented Jan 29, 2021

the tests are failing. I think master may be hardcoded as a keyword somewhere in the protobuf protocol. if you can figure out where that is and do the translation main->master, then the build will probably pass again, and then i think we'd be happy to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants