Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception to expose existing (persistent) subscription response #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtermanis
Copy link
Contributor

  • Distinguish creation failure from already-existing state

- Distinguish creation failure from already-existing state
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #137 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   85.31%   85.25%   -0.07%     
==========================================
  Files           8        8              
  Lines        2254     2258       +4     
  Branches      238      239       +1     
==========================================
+ Hits         1923     1925       +2     
- Misses        275      276       +1     
- Partials       56       57       +1
Impacted Files Coverage Δ
photonpump/exceptions.py 91.3% <100%> (+0.25%) ⬆️
photonpump/conversations.py 95.98% <50%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e83f7...2aa6884. Read the comment docs.

@vtermanis
Copy link
Contributor Author

vtermanis commented Apr 12, 2019

@bobthemighty I probably won't have time to make additional changes here if required before next Wednesday so please do feel free to amend where necessary (as well as in the other PR). I presumse codecov "fails" because there's no test case for actual subscription failure (simulation) and hence that branch is no longer exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant