Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute vaccine effectiveness by groups? #16

Open
Bisaloo opened this issue Jul 11, 2023 · 2 comments
Open

Compute vaccine effectiveness by groups? #16

Bisaloo opened this issue Jul 11, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Jul 11, 2023

Something that was discussed during the vacineff challenge is whether we want vaccineff functions to be able to deal with grouped data out of the box.
One example would be to compute vaccine effectiveness by country in a dataset including multiple countries.

Pros of computing by groups:

  • code could be slightly more efficient than requiring the user to create a loop since we can use vectorized operations
  • fewer lines of code for users

Cons of computing by groups:

  • necessity to add a new argument, which makes the package slightly more difficult to learn
  • slightly more lines of code in package

No matter what is chosen, there should be an example showing how effectiveness can be computed for multiple groups.

@chartgerink
Copy link
Member

Is this question still relevant or has it been parked since? (given that this issue is rather stale by now)

@davidsantiagoquevedo davidsantiagoquevedo added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 31, 2024
@davidsantiagoquevedo
Copy link
Member

Hi @Bisaloo and @chartgerink,

I held off on addressing this issue until we had a well-defined structure for the package. However, it’s a good and relevant idea, and we’ll work on it after submitting to CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants