Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a devcontainer #120

Open
Bisaloo opened this issue Jan 9, 2024 · 3 comments
Open

Consider adding a devcontainer #120

Bisaloo opened this issue Jan 9, 2024 · 3 comments

Comments

@Bisaloo
Copy link
Member

Bisaloo commented Jan 9, 2024

So:

  • Docker users can get started immediately with a working system including all necessary dependencies
  • Developers away from a computer with a working installation (or on a phone) can still access R via GitHub Codespaces
@Bisaloo
Copy link
Member Author

Bisaloo commented Jan 24, 2024

cc @joshwlambert. This could address some of your concerns about the difficulty to set up a working development environment for contributors.

My main concern here is that it would potentially require some knowledge of docker, which doesn't necessarily seems like a step towards an easier setup.

Do you have thoughts on this?

@joshwlambert
Copy link
Member

I've never used docker, so I'm unable to comment on whether it would be an improvement in ease of contribution, and if it were an improvement, how this trades off with the added complexity of managing the container.

Do you know of any GHA workflows that build and output a container that would not be part of the package but would be temporarily stored as an output of the workflow? This would then give a backup if struggling to install the package.

To explore this option it might be good to have a live run through of initialising docker with an existing Epiverse-TRACE package to get the basics.

@bahadzie
Copy link
Member

Do you know of any GHA workflows that build and output a container that would not be part of the package but would be temporarily stored as an output of the workflow? This would then give a backup if struggling to install the package.

I built one a while ago to speed up the time it takes to run our Github workflows pipelines. At the time the only workflow that I couldn't run in the container was pkgdown which had dependencies on an OS library called libv8.

I can look into installing an existing Epiverse-TRACE package if we still want to investigate this option. Let me know which package if any you would like me to use as a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants