-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggest rename function remove_constants()
to remove_constant_cols()
#164
Comments
remove_constant_cols()
and remove_duplicate_rows()
remove_constant_cols()
and remove_duplicate_rows()
remove_constant_cols()
and remove_duplicate_rows()
remove_constants()
to remove_constant_cols()
by looking closer to the reference manual of |
Note that |
after meeting with @Karim-Mane in the week this issue was filled, we defined some possible actions. One is to clarify the documentation, like defining a constant (or invariant) column or row and specifying empty columns or rows as a particular case. If this issue is no longer specific to solve, I agree to close it in favour of another, more specific issue. |
remove_constant()
is a function whose name could be more explicit to facilitate its recall during analysis. An alternative name may need to considerremove_duplicate
which is related but in a different orientation.The proposed alternative is
remove_constant_cols()
and, sinceremove_duplicate_rows()
cc: @Joskerus @lgbermeo
The text was updated successfully, but these errors were encountered: