Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest rename function remove_constants() to remove_constant_cols() #164

Open
avallecam opened this issue Jul 25, 2024 · 3 comments
Open

Comments

@avallecam
Copy link
Member

avallecam commented Jul 25, 2024

remove_constant() is a function whose name could be more explicit to facilitate its recall during analysis. An alternative name may need to consider remove_duplicate which is related but in a different orientation.

The proposed alternative is remove_constant_cols() and, since remove_duplicate_rows()

cc: @Joskerus @lgbermeo

@avallecam avallecam changed the title suggest to rename function remove_constant_cols() and remove_duplicate_rows() suggest rename function on removing constants or duplicates to remove_constant_cols() and remove_duplicate_rows() Jul 29, 2024
@avallecam avallecam changed the title suggest rename function on removing constants or duplicates to remove_constant_cols() and remove_duplicate_rows() suggest rename function remove_constants() to remove_constant_cols() Jul 29, 2024
@avallecam
Copy link
Member Author

by looking closer to the reference manual of remove_constants(), this function also remove constant rows. But more specifically, empty rows and columns. Still, are there any alternative names anyone would like to consider?

@Bisaloo
Copy link
Member

Bisaloo commented Jul 29, 2024

Note that remove_constants() also has a quasi-conflict with the function it's wrapping: janitor::remove_constant(), which is probably not ideal.

@avallecam
Copy link
Member Author

avallecam commented Sep 30, 2024

after meeting with @Karim-Mane in the week this issue was filled, we defined some possible actions. One is to clarify the documentation, like defining a constant (or invariant) column or row and specifying empty columns or rows as a particular case.

If this issue is no longer specific to solve, I agree to close it in favour of another, more specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants