Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill NAs with 0s by default in prepare_data.incidence2 #82

Closed
pratikunterwegs opened this issue Sep 15, 2023 · 0 comments · Fixed by #100
Closed

Fill NAs with 0s by default in prepare_data.incidence2 #82

pratikunterwegs opened this issue Sep 15, 2023 · 0 comments · Fixed by #100

Comments

@pratikunterwegs
Copy link
Collaborator

If a default value of FALSE is more likely to cause issues, why not set it to TRUE and throw a message informing the user about the operation? In fact, I would argue that this not be an argument at all but rather operate under a value of TRUE assumption, which should be documented as part of the data argument and discussed in the details section of the function.

Originally posted by @jamesmbaazam in #78 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant