Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow initialization from endpointSpecs directory #56

Merged
merged 19 commits into from
Oct 8, 2024
Merged

Allow initialization from endpointSpecs directory #56

merged 19 commits into from
Oct 8, 2024

Conversation

ajtucker
Copy link
Contributor

@ajtucker ajtucker commented Oct 4, 2024

A sapi client is normally initialised using a base URL and path to an application.yaml file:

SapiClient::Application.new(base_url, 'some/path/application.yaml')

This PR adds the ability to pass an endpointSpecs directory instead, e.g.:

SapiClient::Application.new(base_url, 'some/path/endpointSpecs')

This is in support of https://github.com/epimorphics/fsa-rpa-api/issues/13 and retains backward compatibility with the existing initialisation method.

@ajtucker
Minimal, backwards compatible change to take path to application.yaml…
ce6915f 
… or endpointSpecs directory.
@ajtucker
Allow tests to run in IntelliJ
d72396d
@ajtucker
Test passing either application.yaml or endpointSpecs directory.
5c66065
@ajtucker
Bump minor version
6fffedd
@ajtucker
bundle install makes minor updates
ea7d75f
@ajtucker
Fix lints and missing string interpolation that rubocop misdiagnosed.
fac3c6b
@ajtucker
Ensure instance vars are nil if not used.
bc4f79a
@ajtucker
Remove some space chars.
1121e0f
@ajtucker
Update error message.
10f0cad
@ajtucker
Update wording in cli app.
3d29797
@ajtucker
bundle update
d3a7982
@ajtucker
Add CHANGELOG entry
26b7ef1
@ajtucker
Update README and add note on model spec files.
218ccd1
@ajtucker
Revert "Allow tests to run in IntelliJ"
88399d9 
This reverts commit d72396d.
@ajtucker
Allow mocha updates to get to 2.4.5 to get over incompatibilities wit…
ec28489 
…h newer minitest.
joescottdave
joescottdave approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@joescottdave joescottdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jonrandahl
jonrandahl approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the versioning constraint updates in the README mentioned below, this looks great to me! 👍

README.md Outdated Show resolved Hide resolved
@ajtucker ajtucker merged commit b4e80d9 into main Oct 8, 2024
11 checks passed
@ajtucker ajtucker deleted the issue/55-initialize-with-endpoints-directory branch October 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrandahl jonrandahl jonrandahl approved these changes

@joescottdave joescottdave joescottdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajtucker @jonrandahl @joescottdave