Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/144 ruby rails upgrades #145

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Conversation

bogdanadrianmarc
Copy link
Contributor

This PR addresses issue #144 by upgrading ruby and rails for the landing app. Also pulls the latest LR Common Styles and Qonsole gem versions (which were also upgraded)

Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

My only comment I think would be to work as a team to set the local paths of our gems to be the same and minimise the need to change them per developer

@bogdanadrianmarc bogdanadrianmarc merged commit 6cac147 into dev Oct 28, 2024
2 checks passed
@bogdanadrianmarc bogdanadrianmarc deleted the issue/144-ruby-rails-upgrades branch October 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants