Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing - Ensure links are distinguished #127

Merged
merged 4 commits into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
This app presents the landing page experience for landregistry.data.gov.uk,
including the SPARQL Qonsole

## 1.7.7 - 2024-08

- (Dan) Adds underlines to links in body text to meet WCAG 2.2 accessibiliy requirments[GH-126](https://github.com/epimorphics/lr-landing/issues/126)

## 1.7.6 - 2024-03-12

- (Jon) Reconfigured the `detailed documentation` links, both english and welsh,
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ cd lr-landing &&
bundle install
```

#### Trouble shooting bundle install

If bundle install does not work add a .bundle directory and create a config
file. So you now have .bundle/config.
Add the following line to the config file.
BUNDLE_RUBYGEMS__PKG__GITHUB__COM: "your-username:your-personal-access-token"
Then run bundle install again and eveything should work.

Start the app locally for development:

```sh
Expand Down
9 changes: 9 additions & 0 deletions app/assets/stylesheets/application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,12 @@
"bootstrap",
"qonsole_rails/application",
"lr_common_styles/lr-common";

.row {
li,p,dl>dt,dl>dd {
a {
text-decoration: underline;
}
}
}

2 changes: 1 addition & 1 deletion app/lib/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Version
MAJOR = 1
MINOR = 7
REVISION = 6
REVISION = 7
SUFFIX = nil
VERSION = "#{MAJOR}.#{MINOR}.#{REVISION}#{SUFFIX && ".#{SUFFIX}"}"
end