Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up renewal #87

Open
seabbs opened this issue Mar 1, 2023 · 2 comments
Open

Speed up renewal #87

seabbs opened this issue Mar 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@seabbs
Copy link
Contributor

seabbs commented Mar 1, 2023

The renewal code can be sped up using a dot product vs its current implementation. This a core part of the simulation code and so would give a good speed up. However, if planning on using thee EpiNow2 simulation model then this change is not needed as this part of the code base will be depreciated I would imagine.

~ sum(cases$cases * draw_from_si_prob(

@seabbs seabbs added the enhancement New feature or request label Mar 1, 2023
@sbfnk
Copy link
Contributor

sbfnk commented Mar 2, 2023

Yes, making EpiNow2 a dependency and fully basing it on that probably makes sense.

@seabbs
Copy link
Contributor Author

seabbs commented Mar 2, 2023

The cost is of course the terrifying requirement for stan and the dreaded maybe having to compile something. There could be an easy argument for having a duplicate R based simulator in this package (which wouldn't need to have feature parity) and making it optional for the user.

The dependency structure would get complicated but that could also have utility in EpiNow2 (this was how EpiNow and the forecasting component of EpiNow2 worked before being depreciated.

The other option is pulling out or resuing some of the epinowcast R code that makes doing this stuff more matrix focused.

The final options is depending on an external package, for example projections, but that seems like a risky dependency and has made some design decisions that could make its use tricky for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants