fix prettier error for unknown file types in writeIfChanged #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses an issue where running Prettier on created svg files throws an error. The issue is caused by Prettier not recognizing the
.svg
file format by default.Steps to Reproduce:
writeIfChanged
function attempts to run Prettier on thesprite.svg
file.Changes:
--ignore-unknown
flag to theprettier --write
command in thewriteIfChanged
function. This ensures that Prettier will gracefully ignore file types it does not recognize, rather than throwing an error.Relevant Documentation:
Prettier's
--ignore-unknown
flag is used to ignore unknown files matched by patterns.Fixes:
Thank you @sergio-codel-io for reporting the issue