fix notes image upload

[arpitdalal]

Image upload for notes has a bug where only adding an image to an existing note deletes the old one and only adds the new one. (See below video)

edit.images.not.working.correctly.mp4

This happens because the file entries without File are being stripped away by this function and since the existing images are only being passed as id in a hidden field, they're being stripped away.
As a solution, I've updated that function not to strip away any images that have id, see here and update related code in transform and prisma query.
See this video after this fix

edit.images.working.correctly.mp4

Let me know if you need me to make any changes.

Test Plan

I couldn't find any tests already written for this, so haven't updated anything.

Checklist

• Tests updated
• Docs updated

Screenshots

[kentcdodds]

Thank you for this! I've adjusted the approach and I think it simplified things quite a bit. I appreciate you bringing this to my attention! I'm recording the video for EpicWeb.dev where we build this part of the app right now so it was very timely :)