-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reflame deploys, add example visual tests #457
Changes from 8 commits
31d3c76
b794858
2984558
08c4389
42f2c35
d08a7ac
f0e9981
098216a
ef283e1
4dc0fe1
dc4b5ef
31b4120
4836561
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -174,6 +174,25 @@ | |
"/chains", | ||
"/" | ||
] | ||
}, | ||
"@ucanto/core": { | ||
"entryPoints": [ | ||
"/delegation", | ||
"/" | ||
] | ||
}, | ||
"@ucanto/principal": { | ||
"entryPoints": [ | ||
"/ed25519", | ||
"/" | ||
] | ||
} | ||
}, | ||
"npmPackageOverrides": { | ||
// This package is specified as a git dependency: https://github.com/web3-storage/w3up/blob/d6978d7ab299be76987c6533d18e6857f6998fe6/packages/access-client/package.json#L113 | ||
// which Reflame doesn't support yet | ||
// Luckily looks like the only reason for doing this was to point to a fork that fixes types: https://github.com/fission-codes/one-webcrypto/commit/5148cd14d5489a8ac4cd38223870e02db15a2382 | ||
// which is irrelevant to the Reflame deploy, so we can safely just point to the original package | ||
"one-webcrypto": "npm:[email protected]" | ||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import Blockies from "react-blockies"; | ||
import xmtpIconUrl from '../../../images/xmtp-icon.png' | ||
|
||
interface AvatarProps { | ||
/** | ||
|
@@ -47,3 +48,7 @@ export const Avatar = ({ url, isLoading, address }: AvatarProps) => { | |
</div> | ||
); | ||
}; | ||
|
||
export const Avatar_test = <Avatar url={xmtpIconUrl} /> | ||
export const AvatarWithAddress_test = <Avatar address="1234" /> | ||
export const AvatarLoading_test = <Avatar isLoading /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is all it takes to add visual tests in Reflame! :) You can see the results in the GitHub checks page: https://github.com/xmtp-labs/xmtp-inbox-web/pull/457/checks?check_run_id=22371292908 Happy to remove it if you don't plan on making use of this at all. But would love to have y'all try it out and hear what you think if you're up for it! |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ | |
width: 50px; | ||
height: 50px; | ||
transform: scale(0.1); | ||
background-image: url("../../../../public/xmtp-icon.png"); | ||
background-image: url("../../../images/xmtp-icon.png"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Had to move this out of public folders since Reflame doesn't support it yet. Part of the reason we don't support it yet is because assets in the public folder can't take advantage of content-hashing (e.g. turning xmtp-icon.png into xmtp-icon-somehash1234.png) to allow for semi-permanent caching without worrying about invalidation. It didn't seem like any of the images currently in public needed to be there as far as I could tell, so I moved them out and updated all the references here. Let me know if you have concerns with this, happy to adjust. |
||
background-size: 50px auto; | ||
border-radius: 50%; | ||
animation: fall linear infinite; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
import './globals.css' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some context here so we can remove this when they eventually upstream their types change.