-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sponsor List organism #753
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4910a74
New Sponsor List organism
xentenza 5f2ef14
Sponsor List: new variant
xentenza 7413529
update: Sponsor Link list
xentenza e387b41
Link in Figcaption
xentenza 62e9edc
Update sponsor-list-link.twig
xentenza c7d18b3
Deleted align-items-center .class
xentenza bb9dffe
Alt text
xentenza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<figure> | ||
<a href="#"> | ||
<img class="img-fluid d-block mx-auto" src="./images/styleguide/illustrations/brand-identity-teaser.png" alt="EPFL"> | ||
</a> | ||
<hr> | ||
<figcaption><a href="#">Lorem ipsum dolor sit amet.</a></figcaption> | ||
<hr class="bold"> | ||
</figure> |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Même remarque concernant l'attribut ALT. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
title: Sponsor | ||
name: sponsor | ||
variants: | ||
- name: link | ||
title: Sponsor with link |
11 changes: 11 additions & 0 deletions
11
assets/components/organisms/sponsor-list/sponsor-list-link.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<div class="row justify-content-center"> | ||
<div class="col-md-4"> | ||
{% include '@molecules/sponsor/sponsor-link.twig' %} | ||
</div> | ||
<div class="col-md-4"> | ||
{% include '@molecules/sponsor/sponsor-link.twig' %} | ||
</div> | ||
<div class="col-md-4"> | ||
{% include '@molecules/sponsor/sponsor-link.twig' %} | ||
</div> | ||
</div> |
11 changes: 11 additions & 0 deletions
11
assets/components/organisms/sponsor-list/sponsor-list.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<div class="row justify-content-center"> | ||
<div class="col-md-4"> | ||
{% include '@molecules/sponsor/sponsor.twig' %} | ||
</div> | ||
<div class="col-md-4"> | ||
{% include '@molecules/sponsor/sponsor.twig' %} | ||
</div> | ||
<div class="col-md-4"> | ||
{% include '@molecules/sponsor/sponsor.twig' %} | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
title: Sponsor List | ||
name: sponsor-list | ||
variants: | ||
- name: link | ||
title: Sponsor List with link |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le contenu de l'attribut ALT devrait reprendre le texte présent sur le logo, pas indiquer "Sponsor". Ici par exemple juste "EPFL".