Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sponsor List organism #753

Merged
merged 7 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions assets/components/molecules/sponsor/sponsor-link.twig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le contenu de l'attribut ALT devrait reprendre le texte présent sur le logo, pas indiquer "Sponsor". Ici par exemple juste "EPFL".

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<figure>
<a href="#">
<img class="img-fluid d-block mx-auto" src="./images/styleguide/illustrations/brand-identity-teaser.png" alt="EPFL">
</a>
<hr>
<figcaption><a href="#">Lorem ipsum dolor sit amet.</a></figcaption>
<hr class="bold">
</figure>
2 changes: 1 addition & 1 deletion assets/components/molecules/sponsor/sponsor.twig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Même remarque concernant l'attribut ALT.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<figure>
<img class="img-fluid d-block mx-auto" src="https://via.placeholder.com/300x150.jpg" alt="Sponsor">
<img class="img-fluid d-block mx-auto" src="./images/styleguide/illustrations/brand-identity-teaser.png" alt="EPFL">
<hr>
<figcaption>Lorem ipsum dolor sit amet.</figcaption>
<hr class="bold">
Expand Down
3 changes: 3 additions & 0 deletions assets/components/molecules/sponsor/sponsor.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
title: Sponsor
name: sponsor
variants:
- name: link
title: Sponsor with link
11 changes: 11 additions & 0 deletions assets/components/organisms/sponsor-list/sponsor-list-link.twig
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<div class="row justify-content-center">
<div class="col-md-4">
{% include '@molecules/sponsor/sponsor-link.twig' %}
</div>
<div class="col-md-4">
{% include '@molecules/sponsor/sponsor-link.twig' %}
</div>
<div class="col-md-4">
{% include '@molecules/sponsor/sponsor-link.twig' %}
</div>
</div>
11 changes: 11 additions & 0 deletions assets/components/organisms/sponsor-list/sponsor-list.twig
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<div class="row justify-content-center">
<div class="col-md-4">
{% include '@molecules/sponsor/sponsor.twig' %}
</div>
<div class="col-md-4">
{% include '@molecules/sponsor/sponsor.twig' %}
</div>
<div class="col-md-4">
{% include '@molecules/sponsor/sponsor.twig' %}
</div>
</div>
5 changes: 5 additions & 0 deletions assets/components/organisms/sponsor-list/sponsor-list.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
title: Sponsor List
name: sponsor-list
variants:
- name: link
title: Sponsor List with link
Loading