Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search WordPress post #733

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Search WordPress post #733

merged 2 commits into from
Jul 24, 2024

Conversation

xentenza
Copy link
Collaborator

Permettre de rechercher un post de blog WordPress (notamment quand ils sont utilisés pour des archives comme Campus Lectures, Archizoom, etc.)

Permettre de rechercher un post de blog WordPress (notamment quand ils sont utilisés pour des archives comme Campus Lectures, Archizoom, etc.)
Copy link

github-actions bot commented Jun 19, 2024

Test Results

  1 files    1 suites   0s ⏱️
278 tests 273 ✅ 0 💤 0 ❌ 5 🔥
278 runs  268 ✅ 0 💤 5 ❌ 5 🔥

For more details on these errors, see this check.

Results for commit f4cc9a6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 19, 2024

🔎 Download the Backstop report for this pull request (link valid for 90 days):

@@ -16,6 +16,16 @@
<div class="collapse collapse-lg-show collapse-drop" id="form-filters">
<form class="p-3 p-lg-0 mt-md-3">

<div class="form-group">
<form class="border-0 p-0" method="get" name="?s+s">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a 2 <form> imbriqués qui donnent un effet d'ombre sous la barre de recherche avec un mobile.

Screenshot from 2024-06-20 15-59-09

Je crois que si tu enlèves ce form, c'est bon.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williambelle J'avais surtout fait un beau mélange entre charte graphique et développement.

Je me suis donc concentré que sur le graphisme sur ce coup-là. La mise en place du script pour effectuer les recherches, ce sera avec les équipes WP 😊

- added the ability to customize form label names
- added a search field to the blog homepage sidebar
@williambelle williambelle merged commit 0f69bc9 into dev Jul 24, 2024
4 checks passed
@williambelle williambelle deleted the styleguide/search-blog-homepage branch July 24, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants