simplified version removed #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Simplified version" tab removed from news-detail The project has been abandoned.
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
|
|
||
| <div class="tab-content py-3"> | ||
| <div class="tab-pane fade show active" id="original" role="tabpanel" aria-labelledby="original-tab"> | ||
| <div="news-content-text"> |
There was a problem hiding this comment.
Ce <div> semble causer des soucis au niveau des colonnes :
| <div class="tab-pane fade show active" id="original" role="tabpanel" aria-labelledby="original-tab"> | ||
| <div="news-content-text"> | ||
|
|
||
| <span itemprop="description"> |
There was a problem hiding this comment.
Le <span> est bizarre dans ce contexte avec <p> comme enfants.
There was a problem hiding this comment.
Le
<span>est bizarre dans ce contexte avec<p>comme enfants.
@williambelle Je suis d'accord avec toi, j'avais juste recopié ce qui figure actuellement sur actu.epfl.ch
Que penses-tu de ma nouvelle PR? ( itemprop="articleBody" )
- corrected schema.org properties
| @@ -25,20 +25,11 @@ | |||
|
|
|||
| <div class="container"> | |||
| <div class="row"> | |||
| <div class="col-md-6"> | |||
| <div class="col-md-6 ts-news-content"> | |||
There was a problem hiding this comment.
Juste supprimer la classe ts-news-content qui n'est pas nécessaire dans le styleguide. (On l'utilise pour les tests).
- deleted ts-news-content
williambelle
approved these changes
Mar 27, 2024
alinekeller
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project has been abandoned.