Types #166
Merged
Types #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure to kernel (variableFormula extends PredicateFormula)
Note: given ```scala val s: Seq[(Variable, Term)] ``` `s.toMap` crashes dotty. Instead, do `Map(s*)`.
…ing of terms and formulas
…ted. Simplified a couple proofs.
|
This should be ready for merge. |
Merged
|
Looks great overall; I checked as much of the technical stuff as I could at this moment. All theory files pass as well! Minor comments as above ^^^ and then we can merge! |
…n lisa-examples, add a newline in build.properties
sankalpgambhir
approved these changes
Oct 5, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about making a front end for first order logic, allowing to define more specialized Terms, starting with functions, numbers and pairs and ultimately arbitrary types. The implementation aims to be as general as possible to allow for future development.
Incidentally, it solves some unsatisfactory problems of using the Kernel's FOL: The difference between Variables and VariableLabels, runtime assertions to check arity (with the updated "front" this is checked at compile time), etc.
With FOL redefined, it needs to be integrated to the existing proof framework, while maintaining correspondance with kernel objects. Depending of the kind of object, this range from easy to systematic but tedious to non-trivial.