Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance test framework usability and failing test performance fix #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Acceptance test framework usability and failing test performance fix #25

wants to merge 2 commits into from

Conversation

deliciouslytyped
Copy link

Fixes:

  • the acceptance testing framework isn't helpful when the JAR isn't built yet
    • instead: give a more meaningful message
  • if the test case EOFs for some reason, the test will keep going with high CPU usage until it hits the timeout
    • instead: actually check the return value of read() and throw an exception

@deliciouslytyped
Copy link
Author

BTW, spring shell seems to have some WIP testing support now https://docs.spring.io/spring-shell/docs/3.1.6/docs/index.html#using-shell-testing-basics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deliciouslytyped