PR: code review #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbessi
commented
May 2, 2023
There was a problem hiding this comment.
DEPRECATED COMMENTS, IGNORE THEM
I didn't go deeply into code reviewing because of several reasons:
- Please use the default directory structure we provided (f.e. move Monaco_editor and Parser to src directory).
- Only use one Readme (the one provided in root folder). Add sections for Monaco_editor and Parser and be more detailed about how to set up the parser and editor.
- Document the purpose of the files. It is hard to do a meaningful refactoring if it's unclear where to start. F.e. it's not clear how to run the test files or what the purpose of the file grammatik_idee is.
- Also it's not clear to me, if there are deprecated files in this repository (like f.e. medcodelogic.pegjs and new_parser.pegjs).
- It also looks like you didn't upload all of the files.
Please clean up the repo according to these comments and refactor into our provided folder structure.
editor visual changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.