Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pandas 425 #427

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Fix pandas 425 #427

merged 3 commits into from
Sep 15, 2023

Conversation

skon7
Copy link
Contributor

@skon7 skon7 commented Sep 7, 2023 •
edited
Loading

resolves #425

Issue:

#425 (AttributeError: 'DataFrame' object has no attribute 'append')

Description

This pull request addresses issue #425 by replacing the append function with the concat function. The issue was caused by a compatibility problem with pandas versions greater than 2.

Changes Made:

  • Replaced append with concat in relevant code sections notif_bot_POC.ipynb,crypto.py,pse.py and notification.py.

Checklist

  • I am making a pull request from a branch other than master
  • I have read the CONTRIBUTING.md

enzoampil
enzoampil approved these changes Sep 13, 2023
View reviewed changes
Copy link
Owner

@enzoampil enzoampil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skon7
change from_numpy_matrix -> from_numpy_array in networkx because the …
9a6a3ea 
…function removed in new versions to pass all tests (files_changed: 2020-06-10-network_analysis.ipynb,network.py)
@skon7
Copy link
Contributor Author

skon7 commented Sep 13, 2023

the problem because ccxt library uses this api GET https://api.bithumb.com/public/ticker/ALL_BTC and this generate an error FAILED python/tests/test_fastquant.py::test_get_crypto_data - ccxt.base.errors.NetworkError: bithumb GET https://api.bithumb.com/public/ticker/ALL_BTC because of bithumb exchange.

@skon7
Copy link
Contributor Author

skon7 commented Sep 13, 2023

@enzoampil
now all the apis works correctly (https://api.bithumb.com/public/ticker/ALL_BTC),all the tests in tests folder passed 9/9 and also the workflow tested in the localhost with Job succeeded.
build1
build2_3

@enzoampil
Copy link
Owner

thanks lgtm

@enzoampil enzoampil merged commit 805c444 into enzoampil:master Sep 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enzoampil enzoampil enzoampil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'DataFrame' object has no attribute 'append'
2 participants
@skon7 @enzoampil