Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameter-value retrieval from EnzoPhysicsCosmology from EnzoConfig into constructor #403

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mabruzzo
Copy link
Contributor

Pull request summary

Followup from #399. Moved parameter-value retrieval for EnzoPhysicsCosmology from EnzoConfig into constructor (and helper functions).

Detailed Description

This is part of the large migration of Parameter Parsing (that has been split into multiple parts to ease the entire process). The benefits of this migration are highlighted in the user-documentation on the website.

This PR touched slightly more files than other PRs of this general style. I needed to tweak a bunch of places that were directly accessing an EnzoConfig attribute called physics_cosmology. Now those locations just check whether enzo::cosmology()!=nullptr, instead (this is equivalent, we're checking if we're using cosmology). While I was doing that, I realized that some locations included I removed unnecessary accesses to EnzoConfig (most of these accesses became unnecessary because they no longer physics_cosmology, but a few were unnecessary before this change). All of these particular changes were concentrated into the first commit.

The second commit is where I actually relocated the parameter-retrieval logic.

@jwise77 jwise77 self-requested a review May 22, 2024 17:40
@mabruzzo mabruzzo force-pushed the param-prototype-physics-cosmology branch from 627275f to fc977e4 Compare May 22, 2024 20:26
…edshift into EnzoMethodGrackle. This is a bugfix. It turns out we didn't even use the parameter
@mabruzzo mabruzzo force-pushed the param-prototype-physics-cosmology branch from fc977e4 to 9b1b74d Compare May 22, 2024 22:34
@mabruzzo mabruzzo changed the title Param prototype physics cosmology Move parameter-value retrieval from EnzoPhysicsCosmology from EnzoConfig into constructor May 23, 2024
Copy link
Contributor

@jwise77 jwise77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thanks for your patience in my review. Once you address the grackle conflicts, we can merge into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants