Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize stats name for remote address #716

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sanitize stats name for remote address #716

wants to merge 2 commits into from

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Sep 25, 2024

xref: envoyproxy/gateway#4281

alternative for envoyproxy/envoy#36275, because of what Joshua said.

I feel like this change is going to spawn a lot of other changes as well. THere are a ton of places where IP addresses and other things with dots show up in stat names and I'm unsure why this one is different.

@zirain
lint
357faf7 
Signed-off-by: zirain <[email protected]>
arkodg
arkodg approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain zirain mentioned this pull request Sep 26, 2024
Closed
@arkodg
Copy link
Contributor

arkodg commented Oct 1, 2024

ptal @ysawa0 @mattklein123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zirain @arkodg