Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: add sigv4/a test corpuses #36463

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

nbaws
Copy link
Contributor

@nbaws nbaws commented Oct 7, 2024

This patch adds around 160 test cases based on the aws signer test corpus from https://github.com/awslabs/aws-c-auth/tree/main/tests/aws-signing-test-suite

Adding these test cases uncovered the following bugs, which have also been fixed in this patch:

  • Incorrect handling of UTF8 encoded parameters
  • Incorrect date calculation (missing seconds from the date formatter)
  • Invalid handling of tilde within query parameters (also reported by Animal Logic leading to this patch)

Commit Message: aws: add sigv4/a test corpuses
Additional Description:
Risk Level: Low
Testing: Unit
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@nbaws nbaws marked this pull request as draft October 7, 2024 10:16
Signed-off-by: Nigel Brittain <[email protected]>
Signed-off-by: Nigel Brittain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant