Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: Add data buffering for chunks #36411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

wasm: Add data buffering for chunks

655c260
Select commit
Loading
Failed to load commit list.
Open

wasm: Add data buffering for chunks #36411

wasm: Add data buffering for chunks
655c260
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android tests skipped Oct 1, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36411/main@655c260)

juanmolle @juanmolle 655c260 #36411 merge main@a40acb8

wasm: Add data buffering for chunks

Commit Message: wasm: Add data buffering for chunks

Additional Description:
In HTTP/2 connections, the last chunk, which contains the end_of_stream flag, is not used to call the Wasm callback. This fix addresses the issue by dumping the data into the buffer before calling the Wasm callback, ensuring that the data is now present.

Risk Level: Low
Testing: yes
Docs Changes: n/a
Release Notes: yes
Platform Specific Features: n/a

Fixes #35884

Environment

Request variables

Key Value
ref d448899
sha 655c260
pr 36411
base-sha a40acb8
actor juanmolle @juanmolle
message wasm: Add data buffering for chunks...
started 1727813182.634544
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true