xds-failover: disable moving to primary after fallback responds #36386
Envoy/Checks (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Envoy/Checks (pr/36386/main@2cc00f6)
Check started by
Request (pr/36386/main@2cc00f6)
@adisuissa 2cc00f6
#36386 merge
main@ce17605
xds-failover: disable moving to primary after fallback responds
Commit Message: xds-failover: disable moving to primary after fallback responds
Additional Description:
In #35591 Envoy's implementation was modified to allow Envoy move to the primary xDS source, even after the fallback successfully responded.
This PR adds a runtime guard that reverts this behavior. This will be a temporary runtime guard that is introduced to allow testing of the new feature and will be later removed.
Note that there's no change to the current Envoy behavior, unless the runtime guardenvoy.reloadable_features.xds_failover_to_primary_enabled
is explicitly set tofalse
.Risk Level: low - behind a runtime guard.
Testing: Added unit and integration tests.
Docs Changes: N/A
Release Notes: Added an entry.
Platform Specific Features: N/A
Runtime guard:envoy.reloadable_features.xds_failover_to_primary_enabled
was introduced that is set totrue
by default, and keeps the current behavior.
Environment
Request variables
Key | Value |
---|---|
ref | 1309a05 |
sha | 2cc00f6 |
pr | 36386 |
base-sha | ce17605 |
actor | @adisuissa |
message | xds-failover: disable moving to primary after fallback responds... |
started | 1727808211.252127 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 32 |
patch | 0 |
dev | true |