-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update cel-cpp #27414
deps: update cel-cpp #27414
Conversation
Signed-off-by: Kuat Yessenov <[email protected]>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
MSVC does not support weak linkage with ABSL_ATTRIBUTE_WEAK. |
Signed-off-by: Kuat Yessenov <[email protected]>
It turns out the weak linkage is not necessary for this version of CEL since the new code is not active. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on upstreaming the CEL patches, they look painful to maintain.
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov it seems this is throwing a lot of warnings in our build - a lot seem to be essentially the same warning Im guessing we can ~safely ignore the warnings - if so im wondering if we can suppress them in the patch or similar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the help with updating CEL!
A new update to cel-cpp is in progress google/cel-cpp#167, but it requires very recent protoc/absl - which will not happen quickly. |
Will apply the changes in the patch to the cel-cpp SoT repo. However we still need to sort out some issues before we can use cel-cpp HEAD. At this point this will allow CEL matcher work to proceed and patch will go away once we can finally depend on the most recent cel-cpp. |
* deps: update cel-cpp Signed-off-by: Kuat Yessenov <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
* deps: update cel-cpp Signed-off-by: Kuat Yessenov <[email protected]> Signed-off-by: Kuat <[email protected]>
Commit Message: Updates cel-cpp to latest in OSS. There's another export coming so this PR will be followed up. However, the new export needs the latest protoc, absl, and re2 - which may cause other problems. There is a macro pollution problem with proxy-wasm/proxy-wasm-cpp-sdk#154 addressed by a local patch. I will upstream cel-cpp patch separately.
Risk Level: low
Testing: unit
Docs Changes: none