feat: set unordered head mode to true by default #292
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenhamPreen
force-pushed
the
dp/multichain-unordered-default
branch
from
094001b
to
2cc667b
Compare
JasoonS
approved these changes
Oct 25, 2024
DZakh
reviewed
Oct 25, 2024
|
@DenhamPreen, as Dmitry says there's a known potential issue with rollbacks in unordered multichain mode. Can we wait until it's patched before including this in a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry took me some time to get to this,
I string searched the rollback setting and ammended it where ever I saw that then did a sanity check to see if I might have missed it elsewhere. I'm confident it should be set everywhere but maybe you're aware of somewhere I'm not thinking of :)