Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving matplotlib figures as images assigned to experiments #311

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

urig
Copy link
Collaborator

@urig urig commented Jul 5, 2022

This PR introduces a new feature where users can associate matplotlib figures to experiments and save them in the Entropy DB. The figures are saved as PNG images and can be viewed (but not aggregated) in the Entropy Dashboard app.

This PR also removes the deprecated "Plots API" and associated Python classes. The Plots table in the Entropy DB is not affected.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Unit Test Results

332 tests   326 ✔️  54s ⏱️
    1 suites      6 💤
    1 files        0

Results for commit 29b99b8.

♻️ This comment has been updated with latest results.

@urig urig force-pushed the matplotlib_figures branch from ced7b65 to 2fe3952 Compare July 5, 2022 12:48
@galwiner
Copy link
Contributor

great! I think that for this feature to be complimentary to add_figure we need to make add_figure() (in execution.py, row 62) to be able to take matplotlib figures OR add a different method in the same place that takes such figures.
@urig what do you say?

@urig
Copy link
Collaborator Author

urig commented Jul 12, 2022

You're absolutely right that we need to augment EntropyContext to allow saving matplolib figures. I'm inclined towards a separate method so as to be consistent with lower level APIs but getting a single method to handle both is also a good option. Let me know which you prefer.

@galwiner
Copy link
Contributor

@urig let's have a single method handling both. Sorry it took a while to reply, I didn't get notification you answered

@urig urig force-pushed the matplotlib_figures branch from 2fe3952 to e85bb17 Compare July 26, 2022 12:39
@urig urig force-pushed the matplotlib_figures branch from e85bb17 to 29b99b8 Compare September 15, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants