Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove test relying on S3 access #7911

Closed
wants to merge 1 commit into from
Closed

remove test relying on S3 access #7911

wants to merge 1 commit into from

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Sep 27, 2023 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review September 27, 2023 17:13
@radeusgd
Copy link
Member

I'd happily merge this as part of my #7875 because it is blocked on this test failing.

radeusgd added a commit that referenced this pull request Sep 27, 2023
@radeusgd
backport #7911 to avoid CI failure
3af2039
@radeusgd
Copy link
Member

It will be integrated as part of #7875 so I'm closing this PR for now

@radeusgd radeusgd closed this Sep 27, 2023
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 27, 2023
@GregoryTravis GregoryTravis deleted the wip/gmt/5105-remove-s3-read-test branch May 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregoryTravis @radeusgd