Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta.Type.find a type by FQN #7885

Merged
merged 12 commits into from
Oct 2, 2023
Merged

Meta.Type.find a type by FQN #7885

merged 12 commits into from
Oct 2, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Sep 25, 2023 •
edited
Loading

Pull Request Description

When integrated it fixes #7797 by introducing new Meta.Type.find method.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary. Done in 7b10496
  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.
    • Use more efficient structure instead of iterating all modules - done in 6be79f6

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 25, 2023
@JaroslavTulach JaroslavTulach self-assigned this Sep 25, 2023
@JaroslavTulach @radeusgd
Use fully qualified name
0efc7ef 
Co-authored-by: Radosław Waśko <[email protected]>
@enso-bot enso-bot bot mentioned this pull request Sep 26, 2023
Closed
radeusgd
radeusgd approved these changes Oct 2, 2023
View reviewed changes
test/Tests/src/Semantic/Meta_Spec.enso Outdated Show resolved Hide resolved
@JaroslavTulach @radeusgd
should_contain
4df26ca 
Co-authored-by: Radosław Waśko <[email protected]>
@JaroslavTulach JaroslavTulach merged commit 6a59fa5 into develop Oct 2, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/MetaTypeFind_7797 branch October 2, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enso method to get a type/constructor by fully qualified name
3 participants
@JaroslavTulach @radeusgd @Akirathan