-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(even more) Dashboard fixes #7877
Conversation
@PabloBuchu / @indiv0 pinging for visibility |
…en `projectState` is missing
@PabloBuchu it is true however, that it's sometimes useful to search the local backend at least, in case the user is opening a project from a file (so the IDE is passed the project ID)... thoughts? |
@somebody1234 Screen.Recording.2023-09-26.at.14.42.34.mov |
ah that's odd, will take a look then |
ah i think that's a regression? may or may not have found the cause. |
changes pushed. not 100% sure about the fix for this one: |
So retrieving works but:
Screen.Recording.2023-09-27.at.11.59.57.mov |
i agree that the empty background is weird though. i can see whether it's possible to display a blank screen until the spinner shows up? |
@PabloBuchu on second thought, i think it's preferable to stick with the empty background for now. it might be possible to show a white screen until the spinner shows up, but if the spinner never shows up then the white screen would never go away |
So the retrieving is broke again. Are we able to fix this on dashboard layer?
Screen.Recording.2023-09-29.at.10.17.56.mov |
@somebody1234 please fix linter and we should be good to merge |
Pull Request Description
It seems like the correct behavior for tables is to not be valid flex children, so the correct fix is to add a
flex
wrapper div.startup.project
is invalidprojectState
is missing from an assetstartup.project
is providedz-index
of top left (page switcher) iconsImportant Notes
Testing should test Firefox and Chrome (testing on Safari is optional) to make sure the following is working correctly:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.