Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(even more) Dashboard fixes #7877

Merged
merged 20 commits into from
Sep 29, 2023
Merged

(even more) Dashboard fixes #7877

merged 20 commits into from
Sep 29, 2023

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Sep 22, 2023

Pull Request Description

Important Notes

Testing should test Firefox and Chrome (testing on Safari is optional) to make sure the following is working correctly:

  • The table looks normal
  • The context menu still triggers below the table (both with and without items being selected)
  • There is no scrollbar if the table is shorter than the viewport

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 22, 2023
@somebody1234
Copy link
Contributor Author

@PabloBuchu / @indiv0 pinging for visibility

@somebody1234 somebody1234 changed the title Fix table layout in Firefox (even more) Dashboard fixes Sep 25, 2023
@PabloBuchu
Copy link
Contributor

I am having problems with -startup.project it looks like it doesn't search for projects locally... also I think it should prioritize local projects over cloud if they have the same names.

Screenshot 2023-09-26 at 13 33 15 Screenshot 2023-09-26 at 13 33 13

@somebody1234
Copy link
Contributor Author

@PabloBuchu startup.project only ever checks on the current backend - i don't think that's a bad thing. we could maybe add a startup.backend if we want to explicitly open a cloud project?

it is true however, that it's sometimes useful to search the local backend at least, in case the user is opening a project from a file (so the IDE is passed the project ID)... thoughts?

@PabloBuchu
Copy link
Contributor

@somebody1234
| only ever checks on the current backend
take a look on the recording. I opened Enso to show that local was latest backend. Then used -startup.project and it only searched in cloud

Screen.Recording.2023-09-26.at.14.42.34.mov

@somebody1234
Copy link
Contributor Author

ah that's odd, will take a look then

@somebody1234
Copy link
Contributor Author

ah i think that's a regression? may or may not have found the cause.
also note that some of the issues above have not been pushed yet

@somebody1234
Copy link
Contributor Author

changes pushed. not 100% sure about the fix for this one:

@PabloBuchu
Copy link
Contributor

changes pushed. not 100% sure about the fix for this one:

So retrieving works but:

  1. After reruning Enso and success retrieval of opened project when I go back to dashboard I don't have play icon. If I now exit the Enso and go back I won't be able to open running project (see video).
  2. The empty bacground screen when you open Enso and when the Enso spinner shows up is weird. Are we able to do something about it? Can we display the Enso spinner from the beginning?
Screen.Recording.2023-09-27.at.11.59.57.mov

@somebody1234
Copy link
Contributor Author

Can we display the Enso spinner from the beginning?
no, it's not part of our codebase

i agree that the empty background is weird though. i can see whether it's possible to display a blank screen until the spinner shows up?

@somebody1234
Copy link
Contributor Author

@PabloBuchu on second thought, i think it's preferable to stick with the empty background for now. it might be possible to show a white screen until the spinner shows up, but if the spinner never shows up then the white screen would never go away

@PabloBuchu
Copy link
Contributor

So the retrieving is broke again. Are we able to fix this on dashboard layer?

[INFO] [2023-09-29T10:18:26+02:00] [org.enso.projectmanager.boot.ProjectManager$] Started server at 127.0.0.1:30535, press enter to kill server
[INFO] [2023-09-29T10:18:27+02:00] [org.enso.projectmanager.protocol.ClientController] Client connected to Project Manager [8152f262-1f9f-4dc0-b8e2-7439d776204a]
[INFO] [2023-09-29T10:18:27+02:00] [org.enso.languageserver.boot.MainModule] Closed Language Server main module.
[INFO] [2023-09-29T10:18:27+02:00] [org.enso.languageserver.boot.LanguageServerComponent] Terminated main module.
[INFO] [2023-09-29T10:18:27+02:00] [ch.qos.logback.classic.net.SocketNode] Caught java.io.EOFException closing connection.
[INFO] [2023-09-29T10:18:27+02:00] [org.enso.projectmanager.infrastructure.languageserver.LanguageServerController] Language server shut down successfully [Project(aeda375b-b841-4755-bdad-3b4799c91113,New_Project_1,New_Project_1,local,UserProject,2023-09-14T10:24:31.402623Z,Some(Edition(Some(2023.2.1-nightly.2023.9.29),None,Map(),Map())),/Users/pawelbuchowski/enso/projects/New_Project_1,Some(2023-09-29T08:18:02.350466Z),Some(2023-09-14T10:24:32Z))].
[WARN] [2023-09-29T10:18:27+02:00] [org.enso.projectmanager.infrastructure.languageserver.ShutdownHookActivator] Shutdown hook activator has no recollection of project aeda375b-b841-4755-bdad-3b4799c91113. Either it was closed already or it never existed. Ignoring.
[INFO] [2023-09-29T10:18:27+02:00] [org.enso.projectmanager.infrastructure.languageserver.LanguageServerKiller] All language servers have been killed.
[INFO] [2023-09-29T10:18:27+02:00] [akka.actor.LocalActorRef] Message [org.enso.projectmanager.infrastructure.languageserver.package$GracefulStop$] from Actor[akka://project-manager/user/language-server-registry/language-server-controller-aeda375b-b841-4755-bdad-3b4799c91113#103816318] to Actor[akka://project-manager/user/language-server-registry/language-server-controller-aeda375b-b841-4755-bdad-3b4799c91113/bootloader-language-server-aeda375b-b841-4755-bdad-3b4799c91113#-1528237616] was not delivered. [1] dead letters encountered, no more dead letters will be logged in next [5.000 min]. If this is not an expected behavior then Actor[akka://project-manager/user/language-server-registry/language-server-controller-aeda375b-b841-4755-bdad-3b4799c91113/bootloader-language-server-aeda375b-b841-4755-bdad-3b4799c91113#-1528237616] may have terminated unexpectedly. This logging can be turned off or adjusted with configuration settings 'akka.log-dead-letters' and 'akka.log-dead-letters-during-shutdown'.
[INFO] [2023-09-29T10:18:27+02:00] [akka.actor.CoordinatedShutdown] Running CoordinatedShutdown with reason [ActorSystemTerminateReason]
Screen.Recording.2023-09-29.at.10.17.56.mov

@PabloBuchu
Copy link
Contributor

@somebody1234 please fix linter and we should be good to merge

@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Sep 29, 2023
@somebody1234 somebody1234 added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Sep 29, 2023
@mergify mergify bot merged commit 657be61 into develop Sep 29, 2023
24 checks passed
@mergify mergify bot deleted the wip/sb/fix-table-footer branch September 29, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty project opened after pressing enter to confirm project name change
2 participants