Improve HTTP tests #7847
Merged
Improve HTTP tests #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
added
the
CI: No changelog needed
GregoryTravis
requested review from
4e6,
JaroslavTulach,
radeusgd and
jdunkerley
as code owners
radeusgd
reviewed
Sep 19, 2023
radeusgd
reviewed
Sep 21, 2023
jdunkerley
requested changes
Sep 21, 2023
radeusgd
reviewed
Sep 21, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Request_Body.enso
Show resolved
Hide resolved
radeusgd
approved these changes
Sep 21, 2023
JaroslavTulach
approved these changes
Sep 26, 2023
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
| import org.apache.commons.text.StringEscapeUtils; | ||
|
|
||
| public class DummyHandler implements HttpHandler { |
There was a problem hiding this comment.
Why is this class called DummyHandler?
| @@ -8,6 +8,7 @@ import Standard.Base.Network.HTTP.Request_Body.Request_Body | |||
| import Standard.Base.Network.HTTP.Request_Error | |||
| import Standard.Base.Network.Proxy.Proxy | |||
| import Standard.Base.Runtime.Context | |||
| from Standard.Base.Network.HTTP import resolve_headers | |||
There was a problem hiding this comment.
This test is only executed if:
## To run this test locally:
$ sbt 'simple-httpbin/run localhost 8080'
$ export ENSO_HTTP_TEST_HTTPBIN_URL=http://localhost:8080/
Why don't we move the code from simple-httpbin into enso-test-java-helpers and let this Http_Spec start the server on its own?
There was a problem hiding this comment.
That sounds like a really cool idea indeed!
There was a problem hiding this comment.
I'll break this out as a separate task.
|
@JaroslavTulach The purpose of this was not to improve the test infrastructure, but to provide better testing of |
|
@JaroslavTulach Renamed |
jdunkerley
approved these changes
Sep 26, 2023
| } | ||
| } | ||
|
|
||
| private String parsseTextEncoding(String contentType) { |
There was a problem hiding this comment.
Suggested change
| private String parsseTextEncoding(String contentType) { | |
| private String parseTextEncoding(String contentType) { |
GregoryTravis
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.