New GUI/IDE build script support #7832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwu-tow
added
CI: No changelog needed
…into wip/mwu/new-ide-build
# Conflicts: # .vscode/settings.json # app/gui2/package-lock.json # app/gui2/vite.config.ts
…into wip/mwu/new-ide-build
mwu-tow
force-pushed
the
wip/mwu/new-ide-build
branch
from
bd5bf64 to
0028361
Compare
# Conflicts: # Cargo.lock # app/gui2/package-lock.json # app/gui2/package.json # app/gui2/rust-ffi/Cargo.toml # build/build/src/project/ide.rs # build/cli/src/lib.rs
|
Yup, thank you for catching this!
sob., 30 wrz 2023 o 23:30 somebody1234 ***@***.***>
napisał(a):
… ***@***.**** commented on this pull request.
------------------------------
In app/ide-desktop/lib/client/electron-builder-config.ts
<#7832 (comment)>:
> @@ -99,7 +99,7 @@ export function createElectronBuilderConfig(passedArgs: Arguments): electronBuil
extraMetadata: {
version: BUILD_INFO.version,
},
- copyright: 'Copyright © 2022 ${author}.',
+ copyright: `Copyright © ${new Date().getFullYear()} ${common.PRODUCT_NAME}`,
is this supposed to be common.COMPANY_NAME instead?
—
Reply to this email directly, view it on GitHub
<#7832 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL2A5Z44PETA5PYMOFKTY3X5CFPFANCNFSM6AAAAAA44Z5IMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mwu-tow
requested review from
PabloBuchu,
indiv0,
MichaelMauderer,
farmaazon,
kazcw and
vitvakatu
as code owners
|
Would be good to have PR description filled in for those not being in the loop :) |
PabloBuchu
reviewed
Oct 2, 2023
.prettierignore
Outdated
| .vscode | ||
|
|
||
| # Stray files generated during build | ||
| svm_*.md |
Frizi
approved these changes
Oct 2, 2023
PabloBuchu
reviewed
Oct 2, 2023
.vscode/settings.json
Outdated
| } | ||
| }, | ||
| "cmake.configureOnOpen": false | ||
| } |
PabloBuchu
reviewed
Oct 2, 2023
build/cli/src/lib.rs
Outdated
| // inner: input.await?, | ||
| // }, | ||
| // should_upload_artifact: upload_artifact, | ||
| // }) |
There was a problem hiding this comment.
please remove commented code if not needed
…mwu/new-ide-build
…mwu/new-ide-build
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for the new Vue-based GUI (aka
gui2).The user-facing changes are primarily:
./run gui2and./run ide2commands (that build just the new GUI and the whole IDE package with new GUI embedded — respectively);testandlintcommands will now invoke the relevant commands on the new GUIImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.