-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes to the top bar styles #7802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bunch of suggestions.
side note: i think you can @import url('https://fonts.googleapis.com/css2?family=M+PLUS+1:wght@500;600&display=swap')
in base.css
btw, instead of using a link rel="stylesheet"
note to self: you can manually add the transition classes like dropdown-leave-to
to debug specific states, if, say, the animation endpoint isn't correct
oh, also the |
Thank you for review @somebody1234, all suggestions applied. I also had to remove |
i've taken the liberty to merge this with develop, the only conflict should be from the viz pr anyway so it should be safe enough |
Pull Request Description
My first attempts to work with the
gui2
codebase. When looking at the IDE, I noticed that the top bar seems slightly off. I checked and confirmed that the sizes (heights) of some elements were not matching Figma.Also, I tried using the
M PLUS 1
font, and it has a completely different baseline than our previous one, effectively shifting all text down. I think we need to start using it as soon as possible, or else we will fix CSS rules everywhere.I understand that the way I added the font is not the correct one, but I guess we can live with that until we properly include the files to the package.
Please forgive me, gods of Vue.js, @Frizi and @somebody1234, for this murder.
Before:
After:
Dropdown animation:
Kapture.2023-09-19.at.20.01.41.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.