Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to the top bar styles #7802

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Sep 12, 2023

Pull Request Description

My first attempts to work with the gui2 codebase. When looking at the IDE, I noticed that the top bar seems slightly off. I checked and confirmed that the sizes (heights) of some elements were not matching Figma.

Also, I tried using the M PLUS 1 font, and it has a completely different baseline than our previous one, effectively shifting all text down. I think we need to start using it as soon as possible, or else we will fix CSS rules everywhere.

I understand that the way I added the font is not the correct one, but I guess we can live with that until we properly include the files to the package.

Please forgive me, gods of Vue.js, @Frizi and @somebody1234, for this murder.

Before:

Screenshot 2023-09-13 at 12 19 18 AM

After:

Screenshot 2023-09-19 at 8 01 18 PM

Dropdown animation:

Kapture.2023-09-19.at.20.01.41.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu requested a review from Frizi as a code owner September 12, 2023 20:26
@vitvakatu vitvakatu self-assigned this Sep 12, 2023
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of suggestions.

side note: i think you can @import url('https://fonts.googleapis.com/css2?family=M+PLUS+1:wght@500;600&display=swap') in base.css btw, instead of using a link rel="stylesheet"

note to self: you can manually add the transition classes like dropdown-leave-to to debug specific states, if, say, the animation endpoint isn't correct

app/gui2/src/components/ExecutionModeSelector.vue Outdated Show resolved Hide resolved
app/gui2/src/components/NavBreadcrumb.vue Outdated Show resolved Hide resolved
app/gui2/src/components/ProjectTitle.vue Outdated Show resolved Hide resolved
app/gui2/src/assets/base.css Outdated Show resolved Hide resolved
@somebody1234
Copy link
Contributor

oh, also the icon in GraphNode looks a bit too low now, the class should probably be renamed to grab-handle so that it doesn't conflict with the global icon style

@vitvakatu
Copy link
Contributor Author

Thank you for review @somebody1234, all suggestions applied. I also had to remove font-weight from * selector in base.css, because it was conflicting with font-weight of the execution mode label. Screencast updated

@Frizi Frizi added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 22, 2023
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Sep 25, 2023
@somebody1234
Copy link
Contributor

somebody1234 commented Sep 26, 2023

i've taken the liberty to merge this with develop, the only conflict should be from the viz pr anyway so it should be safe enough

@mergify mergify bot merged commit fbfaeb5 into develop Sep 26, 2023
23 checks passed
@mergify mergify bot deleted the wip/vitvakatu/gui2-top-bar branch September 26, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants