Benchmark shall loop correctly #7781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
hubertp
approved these changes
Sep 11, 2023
At the end the slowdown doesn't seem that bad. Maybe I skewed measurements on my local computer earlier today. |
JaroslavTulach
commented
Sep 11, 2023
|
|
||
| sum_multi list (acc:Text|Decimal|Integer|Any) = | ||
| case list of | ||
| Nil -> acc | ||
| Cons x xs -> @Tail_Call sum xs acc+x | ||
| Cons x xs -> @Tail_Call sum_multi xs acc+x |
There was a problem hiding this comment.
Bench runs in between 140-150ms per operation.
JaroslavTulach
commented
Sep 11, 2023
|
|
||
| sum_int list (acc:Integer) = | ||
| case list of | ||
| Nil -> acc | ||
| Cons x xs -> @Tail_Call sum xs acc+x | ||
| Cons x xs -> @Tail_Call sum_int xs acc+x |
There was a problem hiding this comment.
Bench runs in between 140-150ms per operation.
JaroslavTulach
commented
Sep 11, 2023
| @@ -104,17 +104,17 @@ sum_conv list (acc:V) = | |||
| sum_any list (acc:Any) = | |||
| case list of | |||
| Nil -> acc | |||
| Cons x xs -> @Tail_Call sum xs acc+x | |||
| Cons x xs -> @Tail_Call sum_any xs acc+x | |||
There was a problem hiding this comment.
Bench runs in between 140-150ms per operation.
|
ListBenchmarks_mapOverList also runs in between 140-150ms. Let's integrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Many
ListBenchmarkswere wrong. They were looping tosuminstead ofsum_xyz. Expect regressions, but more truthful results.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,