-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard tests #7656
Dashboard tests #7656
Conversation
@PabloBuchu that seems to be because the snapshots are platform-specific. i think that's a good thing, because some things (like context menus) are different on each platform. i think the correct move here would be to |
speaking of though, that means these should be run on windows too |
lint check is failing though, one moment... |
I think this should have some CI changes, since we should test for visual regressions on all platforms, but I think maybe that should wait until it's confirmed that we want to merge this (or wait until this is actually merged in, so that there's something to run in those CI actions) |
for anyone testing: this does have new folders (caches, test results) which are |
It does not work in Ubuntu runners without extra dependencies
what, why did lint hang |
76c1f90
to
8160a37
Compare
:D lint finally passes!!! |
this should still get updated screenshots from macos and windows though. (cc @PabloBuchu) |
Removes dependencies that should not be in the root `package.json` Basic testing done with `npm run ci-check`. Introduced by the following PRs (in order of being merged): See blame for more details: https://github.com/enso-org/enso/blame/develop/package.json - #7813 - #7656 (oops) - #7881 # Important Notes None
Pull Request Description
app/ide-desktop/lib/dashboard/
):The purpose of this PR is to introduce the testing framework - more tests can be added later in separate PRs.
Important Notes
To test, run
npm run test
inapp/ide-desktop
, orapp/ide-desktop/lib/dashboard/
. All tests should pass.Individual test types can be run using
npm run test-unit
,npm run test-component
andnpm run test-e2e
inapp/ide-desktop/lib/dashboard/
.Individual end-to-end tests can be run using
npx playwright test -c playwright-e2e.config.ts test-e2e/<file name>.spec.ts
inapp/ide-desktop/lib/dashboard/
.End-to-end tests require internet access to pass (for things like fonts).
This PR does check in screenshots to guard against visual regessions (and/or to make visual changes obvious)
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.