-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer distribution/lib/Standard files when runEngineDistribution #11736
Conversation
The following picture show that while stepping thru the standard libraries...
|
engine/runtime/src/main/java/org/enso/interpreter/runtime/ModuleSources.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/ModuleSources.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/ModuleSources.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I assume correctly that this also works for enso --inspect --run ...
? This will make life of Chrome devtools users easier as well - we can just load the workspace from distribution/lib
...
engine/runtime/src/main/java/org/enso/interpreter/runtime/ModuleSources.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/ModuleSources.java
Outdated
Show resolved
Hide resolved
JVM tests are hitting the |
That is unexpected. Clearly, CI jobs are setting
|
* Special support for reassigning locations of sources when running development version. When | ||
* {@code -ea} is enabled, then we try to locate library files under the {@code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find the -ea
check anywhere. Is this doc up-to-date?
engine/runtime/src/main/java/org/enso/interpreter/runtime/ModuleSources.java
Show resolved
Hide resolved
Wow I didn't use |
Pull Request Description
Prefer
distribution/lib/Standard/*
files over the files inbuilt-distribution/enso-engine-*/enso-0.0.0-dev/lib/Standard/
. This solves the common error when one debugs thru files and edits them just to find out they are rewritten by next build.Important Notes
The support for locating
alternativeFile
is only enabled for developers. E.g. when Enso version is0.0.0-dev
. This is satisfied when one uses:enso$ sbt sbt:enso> runEngineDistribution --run test/Base_Tests --debug
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,