Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Enso_File download to Cloud API changes #11596

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 19, 2024
@radeusgd radeusgd self-assigned this Nov 19, 2024
@radeusgd
Copy link
Member Author

Enso_File_Spec tests are passing so it should be all good. Not sure if worth running Cloud tests on CI as they are failing on develop anyway.

@radeusgd radeusgd marked this pull request as ready for review November 19, 2024 18:01
@radeusgd
Copy link
Member Author

radeusgd commented Nov 26, 2024

Trying 2 new approaches to listing ran tests (as I noticed some broken tests even though green status on develop).

  1. Re-enable listing all tests in CI log on the Extra workflow.
    a. I think there it is useful to see all tests that were run. Failures can be quickly glanced over thanks to recently added annotations.
  2. Trying to enable the Test Report workflow
    a. It was disabled due to a 'not a fork' check, but that was also affecting scheduled and dispatched runs which I don't think was right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants