Add traces to integration tests + suppress one flaky assertion. #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
the
CI: No changelog needed
farmaazon
force-pushed
the
wip/farmaazon/fix-integration-test
branch
from
ff787de
to
43bbad4
Compare
farmaazon
changed the base branch from
develop
to
wip/sb/fix-react-compiler-lints
farmaazon
force-pushed
the
wip/farmaazon/fix-integration-test
branch
from
b8089aa
to
b91e7c4
Compare
farmaazon
force-pushed
the
wip/farmaazon/fix-integration-test
branch
from
b91e7c4
to
c078f4d
Compare
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
changed the title
farmaazon
changed the title
farmaazon
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
Frizi,
vitvakatu and
kazcw
as code owners
farmaazon
requested review from
AdRiley,
jdunkerley and
hubertp
as code owners
| await expect(writeNode.locator('.TableVisualization')).toContainText(OUTPUT_FILE) | ||
| } catch { | ||
| // TODO[ao] | ||
| // The above check is flaky, because sometimes the additional egine run overrides node output back to "dry run". |
somebody1234
approved these changes
Nov 22, 2024
|
might wanna update codeowners too due to the change of path |
|
@farmaazon why we run |
MrFlashAccount
requested changes
Nov 22, 2024
farmaazon
force-pushed
the
wip/farmaazon/fix-integration-test
branch
from
697bf06
to
7092738
Compare
…/fix-integration-test
MrFlashAccount
approved these changes
Nov 22, 2024
5 tasks
…/fix-integration-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #11604
Most issues were caused by a problem with Project List flooding the network with its requests - this was fixed on develop.
But one assertion was flaky - it assumed we will see the "real" run result on
writenode, but sometimes it is immediately overwritten by dry run.But the most important part of this PR is adding traces to Electron packages - it's should be much easier now to debug E2E test failures.
Also renamed the previously misnamed "E2E tests" to "[GUI] integration tests".
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.