Fix displaying of host values in chrome devtools #11468

Akirathan · 2024-11-01T11:52:55Z

Fixes #7890

Pull Request Description

Chrome inspector now displays polyglot objects that have a corresponding Enso builtin type as enso objects:

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.
If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

And only print them when a test fails

JaroslavTulach · 2024-11-06T07:31:00Z

engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/DebuggingEnsoTest.java

+  public TestWatcher testWatcher =
+      new TestWatcher() {
+        @Override
+        protected void failed(Throwable e, Description description) {


Interesting. If this could be the default for defaultContextBuilder.

I was thinking the same way. But I am afraid that in order to implement this, ContextUtils would need to be an abstract class and all the test classes would need to extend it.

Akirathan · 2024-11-06T16:08:39Z

engine/runtime/src/main/java/org/enso/interpreter/runtime/scope/DebugLocalScope.java

+              HostMethodCallNode.getPolyglotCallType(value, symbol, interopUncached);
+          try {
+            switch (polyglotCallType) {
+              case CONVERT_TO_DATE -> {


Here is the main idea. Chrome inspector instrument builds DebugLocalScope which holds a materialized frame with all the bindings. If a binding is a host object that can/should be converted to an appropriate Enso builtin type before sending back to the inspector, it is converted here. This is pretty much the same kind of conversion that is done inside InvokeMethodNode on the self argument before any kind of method dispatch is done.

JaroslavTulach

I'd expand this to other languages than Java - e.g. Python & co.
I don't understand the different between PolyglotCall & the other enum
I still believe the code should be in EnsoLanguage.getLanguageView

engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/DebuggingEnsoTest.java

...ne/runtime/src/main/java/org/enso/interpreter/node/callable/resolver/HostMethodCallNode.java

engine/runtime/src/main/java/org/enso/interpreter/runtime/scope/DebugLocalScope.java

engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/DebuggingEnsoTest.java

JaroslavTulach

Having all of this in getLanguageView should show beneficial in the future. Hopefully.

JaroslavTulach · 2024-11-12T05:59:17Z

engine/runtime/src/main/java/org/enso/interpreter/runtime/data/vector/ArrayBuilder.java

+  }
+
+  @ExportMessage
+  Class<? extends TruffleLanguage<?>> getLanguage() {


Can we add a test (based on ValuesGenerator that verifies all values of EnsoObject respond to this message?

Akirathan · 2024-11-12T17:09:08Z

Blocked by #11538

JaroslavTulach · 2024-11-14T06:49:42Z

Blocked by #11538

How exactly this is blocked by

Implement hasLanguage interop message for all enso objects #11538

?

Akirathan · 2024-11-14T11:47:04Z

How exactly this is blocked by

* [Implement hasLanguage interop message for all enso objects #11538](https://github.com/enso-org/enso/pull/11538)

?

The test in

enso/engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/WarningsTest.java

Line 148 in 339c275

    
           assertEquals("Types without and with warnings are the same", type, warningType);

started to fail on this PR for a Value of primitive 42L. On this PR, v.getMetaObject() on that value returns non-null, but on develop it returns null. And for some reason, warning2.getMetaObject() returns null, thus the test fails. I figured out it would be just easier to first ensure that we stick to correct Truffle contracts and do that in a separate PR.

# Conflicts: # engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/WarningsTest.java

…age. This is a fix after merge of develop.

Primitive values is expected not to have meta object.

Akirathan · 2024-11-26T18:00:54Z

engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/BigNumberTest.java

+    assertThat("Is a number", longVal.isNumber(), is(true));
+    assertThat("Does not fit in int", longVal.fitsInInt(), is(false));
+    assertThat("Fits in long", longVal.fitsInLong(), is(true));
+    assertThat("Does not fit in double (but could)", longVal.fitsInDouble(), is(false));


This is surprising. A value that fits in Long, but does not fit in Double (according to Enso) ??

Note that all of these 3 tests pass in develop

Moreover, the receiver is java.lang.Long:

Seems like there is something funny in PolyglotValueDispatch$PrimitiveValues for Enso language.

Akirathan added 2 commits November 1, 2024 12:24

Remove leftover typo from tests

845e030

Add tests

b80e0b0

Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 1, 2024

Akirathan self-assigned this Nov 1, 2024

Akirathan added 4 commits November 1, 2024 13:09

Discard warnings from the compiler in the test.

1f68c9a

And only print them when a test fails

Remove the test for non-null properties

4289d6c

Update test to reflect that atom with builtin type has null properties

b354f80

Try to convert HostObject in DebugLocalScope.readMember

ae14326

JaroslavTulach reviewed Nov 6, 2024

View reviewed changes

Akirathan commented Nov 6, 2024

View reviewed changes

Akirathan added 4 commits November 8, 2024 11:27

Fix testests

a7c110c

Implement getPolyglotConversionType

c038f55

DebugLocalScope uses getPolyglotConversionType

d2cd44a

Add tests

08c066f

Akirathan marked this pull request as ready for review November 8, 2024 13:23

Akirathan requested review from 4e6 and hubertp as code owners November 8, 2024 13:23

Remove unused method

c18ad2c

Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Nov 8, 2024

JaroslavTulach reviewed Nov 8, 2024

View reviewed changes

This was referenced Nov 8, 2024

enso --jvm fails with InvalidModuleDescriptorException #11274

Closed

Two BindingsMap$ResolvedImport aren't equal and raise exception on the CI #11171

Closed

Akirathan added 8 commits November 11, 2024 12:27

Testing also js and py foreign languages

2c46980

Polyglot conversion logic is in EnsoLanguage.getLanguageView

9134e52

Use only PolyglotCallType

19e3798

long is wrapped in LanguageViewWrapper

e283355

ArrayBuilder exports hasLanguage and getLanguage messages

b95d4bb

Call Value.asString instead of Value.toString

61e363a

Test that WithWarnings has meta object

5fab1da

Implement hasLanguage and getLanguage messages for EnsoBigInt and Text

293811e

EnsoLanguage.getLanguageView returns null by default

f4b199b

JaroslavTulach approved these changes Nov 12, 2024

View reviewed changes

Akirathan mentioned this pull request Nov 12, 2024

Implement hasLanguage interop message for all enso objects #11538

Merged

6 tasks

unfurl-links bot mentioned this pull request Nov 15, 2024

Allow (multi_value : Table) : Column to succeed #11482

Open

Akirathan added 5 commits November 26, 2024 13:31

Merge branch 'develop' into wip/akirathan/7890-java-values-devtools

95b8d09

# Conflicts: # engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/WarningsTest.java

Classes that extend EnsoObject do not export getLanguage and hasLangu…

cdc0ba3

…age. This is a fix after merge of develop.

Build fixes after merge

b743106

Update WithWarning test - do not use primitive value.

368415f

Primitive values is expected not to have meta object.

Add test for polyglot semantics of Enso numbers

19328ac

Akirathan commented Nov 26, 2024

View reviewed changes

Akirathan mentioned this pull request Nov 26, 2024

Enso numbers polyglot API inconsistency #11672

Open

unfurl-links bot mentioned this pull request Nov 26, 2024

Java Values are displayed differently in the Chrome Devtools debugger #7890

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix displaying of host values in chrome devtools #11468

Fix displaying of host values in chrome devtools #11468

Akirathan commented Nov 1, 2024 •

edited

Loading

JaroslavTulach Nov 6, 2024

Akirathan Nov 26, 2024

Akirathan Nov 6, 2024

JaroslavTulach left a comment

JaroslavTulach left a comment

JaroslavTulach Nov 12, 2024

Akirathan commented Nov 12, 2024

JaroslavTulach commented Nov 14, 2024

Akirathan commented Nov 14, 2024

Akirathan Nov 26, 2024

Akirathan Nov 26, 2024

Fix displaying of host values in chrome devtools #11468

Are you sure you want to change the base?

Fix displaying of host values in chrome devtools #11468

Conversation

Akirathan commented Nov 1, 2024 • edited Loading

Pull Request Description

Important Notes

Checklist

JaroslavTulach Nov 6, 2024

Choose a reason for hiding this comment

Akirathan Nov 26, 2024

Choose a reason for hiding this comment

Akirathan Nov 6, 2024

Choose a reason for hiding this comment

JaroslavTulach left a comment

Choose a reason for hiding this comment

JaroslavTulach left a comment

Choose a reason for hiding this comment

JaroslavTulach Nov 12, 2024

Choose a reason for hiding this comment

Akirathan commented Nov 12, 2024

JaroslavTulach commented Nov 14, 2024

Akirathan commented Nov 14, 2024

Akirathan Nov 26, 2024

Choose a reason for hiding this comment

Akirathan Nov 26, 2024

Choose a reason for hiding this comment

Akirathan commented Nov 1, 2024 •

edited

Loading