-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose backend API to IDE #10442
Merged
Merged
Expose backend API to IDE #10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Jul 3, 2024
kazcw
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
Frizi,
farmaazon,
vitvakatu,
AdRiley,
jdunkerley,
JaroslavTulach and
wdanilo
as code owners
July 3, 2024 23:00
kazcw
force-pushed
the
wip/kw/cloud-files/2-backend
branch
from
July 5, 2024 15:52
32d5e19
to
3bb22b4
Compare
kazcw
added
the
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
label
Jul 5, 2024
kazcw
force-pushed
the
wip/kw/cloud-files/2-backend
branch
from
July 9, 2024 15:12
3bb22b4
to
fa654cc
Compare
farmaazon
approved these changes
Jul 10, 2024
somebody1234
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving dashboard changes, they seem to mostly (if not all) be just moving things around)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Move
Backend
and supporting APIs fromdashboard
toenso-common
.Closes #10400.
Important Notes
Backend
have been moved toenso-common
. Those defining general-purpose helpers for working with standard types are now in a submoduleutilities/data
to match the IDE organization; in the future we can merge them with theutil/data
gui2 subtree. Moved utilities are reexported from their dashboard locations, so that moved and not-yet-moved modules can be imported consistently.text
module has been moved toenso-common
; the IDE doesn't have any localization mechanism yet, so we can share this one.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.