Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose backend API to IDE #10442

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Expose backend API to IDE #10442

merged 9 commits into from
Jul 10, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Jul 3, 2024

Pull Request Description

Move Backend and supporting APIs from dashboard to enso-common.

Closes #10400.

Important Notes

  • The utility modules required by Backend have been moved to enso-common. Those defining general-purpose helpers for working with standard types are now in a submodule utilities/data to match the IDE organization; in the future we can merge them with the util/data gui2 subtree. Moved utilities are reexported from their dashboard locations, so that moved and not-yet-moved modules can be imported consistently.
  • The text module has been moved to enso-common; the IDE doesn't have any localization mechanism yet, so we can share this one.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw kazcw self-assigned this Jul 3, 2024
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 3, 2024
@kazcw kazcw marked this pull request as ready for review July 3, 2024 23:00
@kazcw kazcw marked this pull request as draft July 5, 2024 13:57
@kazcw kazcw force-pushed the wip/kw/cloud-files/2-backend branch from 32d5e19 to 3bb22b4 Compare July 5, 2024 15:52
@kazcw kazcw added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jul 5, 2024
@kazcw kazcw force-pushed the wip/kw/cloud-files/2-backend branch from 3bb22b4 to fa654cc Compare July 9, 2024 15:12
@kazcw kazcw changed the title Provide access to backend in IDE Expose backend API to IDE Jul 9, 2024
@kazcw kazcw marked this pull request as ready for review July 9, 2024 15:18
@kazcw kazcw mentioned this pull request Jul 10, 2024
4 tasks
@kazcw kazcw linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving dashboard changes, they seem to mostly (if not all) be just moving things around)

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Jul 10, 2024
@mergify mergify bot merged commit 32e843c into develop Jul 10, 2024
36 checks passed
@mergify mergify bot deleted the wip/kw/cloud-files/2-backend branch July 10, 2024 21:04
@kazcw kazcw mentioned this pull request Jul 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud File Browser: Create library for dashboard/gui common logic
3 participants