Skip to content

Commit

Permalink
Increase timeout of macOS E2E tests (#11837)
Browse files Browse the repository at this point in the history
  • Loading branch information
farmaazon authored Dec 11, 2024
1 parent 9cf7833 commit f1a283b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ jobs:
ENSO_IDE_AG_GRID_LICENSE_KEY: ${{ vars.ENSO_AG_GRID_LICENSE_KEY }}
ENSO_IDE_MAPBOX_API_TOKEN: ${{ vars.ENSO_MAPBOX_API_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- run: corepack pnpm -r --filter enso exec playwright test
- run: corepack pnpm -r --filter enso exec playwright test --timeout 300000
env:
DEBUG: "pw:browser log:"
ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
Expand Down
13 changes: 8 additions & 5 deletions build/build/src/ci_gen/job.rs
Original file line number Diff line number Diff line change
Expand Up @@ -581,12 +581,15 @@ impl JobArchetype for PackageIde {
.customize(move |step| {
let mut steps = prepare_packaging_steps(target.0, step);
const TEST_COMMAND: &str = "corepack pnpm -r --filter enso exec playwright test";
let test_step = if target.0 == OS::Linux {
shell(format!("xvfb-run {TEST_COMMAND}"))
let test_step = match target.0 {
OS::Linux => shell(format!("xvfb-run {TEST_COMMAND}"))
// See https://askubuntu.com/questions/1512287/obsidian-appimage-the-suid-sandbox-helper-binary-was-found-but-is-not-configu
.with_env("ENSO_TEST_APP_ARGS", "--no-sandbox")
} else {
shell(TEST_COMMAND)
.with_env("ENSO_TEST_APP_ARGS", "--no-sandbox"),

OS::MacOS =>
// MacOS CI runners are very slow
shell(format!("{TEST_COMMAND} --timeout 300000")),
_ => shell(TEST_COMMAND),
};
let test_step = test_step
.with_env("DEBUG", "pw:browser log:")
Expand Down

0 comments on commit f1a283b

Please sign in to comment.