Second iteration of Dashboard Fixes (#11781)

Fixes:

- Opening deleted folder
- Icons
- Diff view collapsed
- Password input for passwords in settings
- Save button appears only if form in settings is dirty
- Disable clear trash button if it's empty
- Disable D&D in the root folder
- Disable Create actions if user select a folder without sufficient permissions
- Many more

app/common/src/services/Backend.ts

@@ -1787,3 +1787,17 @@ export default abstract class Backend {
   /** Resolve the path of an asset relative to a project. */
   abstract resolveProjectAssetPath(projectId: ProjectId, relativePath: string): Promise<string>
 }
+
+// ==============================
+// ====== Custom Errors =========
+// ==============================
+
+/** Error thrown when a directory does not exist. */
+export class DirectoryDoesNotExistError extends Error {
+  /**
+   * Create a new instance of the {@link DirectoryDoesNotExistError} class.
+   */
+  constructor() {
+    super('Directory does not exist.')
+  }
+}

app/common/src/text/english.json

@@ -176,6 +176,7 @@
   "emptyStringError": "This value must not be empty.",
 
   "directoryAssetType": "folder",
+  "directoryDoesNotExistError": "Unable to find directory. Does it exist?",
   "projectAssetType": "project",
   "fileAssetType": "file",
   "datalinkAssetType": "Datalink",
@@ -306,22 +307,23 @@
   "andOtherProjects": "and $0 other projects",
 
   "cloudCategory": "Cloud",
-  "myFilesCategory": "Me",
+  "myFilesCategory": "My Files",
   "recentCategory": "Recent",
   "trashCategory": "Trash",
   "userCategory": "$0",
   "teamCategory": "$0",
   "localCategory": "Local",
   "cloudCategoryButtonLabel": "Cloud",
-  "myFilesCategoryButtonLabel": "Me",
+  "myFilesCategoryButtonLabel": "My Files",
   "recentCategoryButtonLabel": "Recent",
   "trashCategoryButtonLabel": "Trash",
   "userCategoryButtonLabel": "$0 (User)",
   "teamCategoryButtonLabel": "$0 (Team)",
   "localCategoryButtonLabel": "Local",
   "cloudCategoryDropZoneLabel": "Move to your organization's home directory",
   "cloudCategoryBadgeContent": "Beta",
-  "myFilesCategoryDropZoneLabel": "Move to your home directory",
+  "uploadToCloudUnavailableForFreePlan": "",
+  "myFilesCategoryDropZoneLabel": "Move to My Files",
   "recentCategoryDropZoneLabel": "Move to Recent category",
   "trashCategoryDropZoneLabel": "Move to Trash category",
   "userCategoryDropZoneLabel": "Move to $0's home directory",
@@ -400,7 +402,7 @@
   "deleteTheAssetTypeTitle": "delete the $0 '$1'",
   "trashTheAssetTypeTitle": "move the $0 '$1' to Trash",
   "notImplemetedYet": "Not implemented yet.",
-  "newLabelButtonLabel": "new label",
+  "newLabelButtonLabel": "New label",
   "settingUsername": "Setting username...",
   "loggingOut": "Logging out...",
   "pleaseWait": "Please wait...",
@@ -415,6 +417,7 @@
   "version": "Version",
   "build": "Build",
   "errorColon": "Error: ",
+  "developerInfo": "Dev mode info",
   "electronVersion": "Electron",
   "chromeVersion": "Chrome",
   "userAgent": "User Agent",
@@ -423,7 +426,7 @@
   "projectSessionX": "Session $0",
   "onDateX": "on $0",
   "xUsersAndGroupsSelected": "$0 users and groups selected",
-  "allTrashedItemsForever": "all trashed items forever",
+  "allTrashedItemsForever": "delete all trashed items forever",
   "addShortcut": "Add shortcut",
   "removeShortcut": "Remove shortcut",
   "resetShortcut": "Reset shortcut",
@@ -482,7 +485,7 @@
   "disableAnimations": "Disable animations",
   "disableAnimationsDescription": "Disable all animations in the app.",
   "removeTheLocalDirectoryXFromFavorites": "remove the local folder '$0' from your favorites",
-  "changeLocalRootDirectoryInSettings": "Change your root folder in Settings.",
+  "changeLocalRootDirectoryInSettings": "Change the root folder",
   "localStorage": "Local Storage",
   "addLocalDirectory": "Add Folder",
   "browseForNewLocalRootDirectory": "Browse for new Root Folder",
@@ -821,6 +824,7 @@
   "arbitraryFieldNotContainAny": "This field does not contain any of the fields",
 
   "arbitraryErrorTitle": "An error occurred",
+  "somethingWentWrong": "Something went wrong",
   "arbitraryErrorSubtitle": "Please try again or contact the administrators.",
   "arbitraryFormErrorMessage": "Something went wrong while submitting the form. Please try again or contact the administrators.",
 
@@ -942,6 +946,10 @@
   "shareFullFeatureDescription": "Share unlimited assets with other users and manage shared assets. Assign shared assets to user groups to manage their permissions.",
   "shareFullPaywallMessage": "You can only share assets with a single user group. Upgrade to share assets with multiple user groups and users.",
 
+  "uploadToCloudFeatureLabel": "Upload to Cloud",
+  "uploadToCloudFeatureBulletPoints": "Upload assets to the Cloud;Manage Cloud assets;Run projects in the Cloud",
+  "uploadToCloudFeatureDescription": "Upload assets to the cloud and manage them in the cloud. Run projects in the cloud.",
+
   "ensoDevtoolsButtonLabel": "Open Enso Devtools",
   "ensoDevtoolsPopoverHeading": "Enso Devtools",
   "ensoDevtoolsPlanSelectSubtitle": "User Plan",

app/common/src/utilities/data/object.ts

@@ -66,6 +66,11 @@ export function unsafeKeys<T extends object>(object: T): readonly (keyof T)[] {
   return Object.keys(object)
 }
 
+/** Return the values of an object. UNSAFE only when it is possible for an object to have extra keys. */
+export function unsafeValues<const T extends object>(object: T): readonly T[keyof T][] {
+  return Object.values(object)
+}
+
 /**
  * Return the entries of an object. UNSAFE only when it is possible for an object to have
  * extra keys.
@@ -77,6 +82,17 @@ export function unsafeEntries<T extends object>(
   return Object.entries(object)
 }
 
+/**
+ * Return an object from its entries. UNSAFE only when it is possible for an object to have
+ * extra keys.
+ */
+export function unsafeFromEntries<T extends object>(
+  entries: readonly { [K in keyof T]: readonly [K, T[K]] }[keyof T][],
+): T {
+  // @ts-expect-error This is intentionally a wrapper function with a different type.
+  return Object.fromEntries(entries)
+}
+
 // =============================
 // === unsafeRemoveUndefined ===
 // =============================

app/gui/integration-test/dashboard/actions/DrivePageActions.ts

@@ -380,4 +380,18 @@ export default class DrivePageActions extends PageActions {
       await callback(locateContextMenus(page))
     })
   }
+
+  /** Close the "get started" modal. */
+  closeGetStartedModal() {
+    return this.step('Close "get started" modal', async (page) => {
+      await new StartModalActions(page).close()
+    })
+  }
+
+  /** Interact with the "start" modal. */
+  withStartModal(callback: baseActions.LocatorCallback) {
+    return this.step('Interact with start modal', async (page) => {
+      await callback(new StartModalActions(page).locateStartModal())
+    })
+  }
 }

app/gui/integration-test/dashboard/actions/StartModalActions.ts

@@ -1,7 +1,7 @@
 /** @file Actions for the "home" page. */
+import * as test from '@playwright/test'
 import * as actions from '.'
 import BaseActions from './BaseActions'
-import DrivePageActions from './DrivePageActions'
 import EditorPageActions from './EditorPageActions'
 
 // =========================
@@ -11,10 +11,31 @@ import EditorPageActions from './EditorPageActions'
 /** Actions for the "start" modal. */
 export default class StartModalActions extends BaseActions {
   /** Close this modal and go back to the Drive page. */
-  close() {
-    return this.step('Close "start" modal', (page) => page.getByLabel('Close').click()).into(
-      DrivePageActions,
-    )
+  async close() {
+    const isOnScreen = await this.isStartModalShown()
+
+    if (isOnScreen) {
+      return test.test.step('Close start modal', async () => {
+        await this.locateStartModal().getByTestId('close-button').click()
+      })
+    }
+  }
+
+  /** Locate the "start" modal. */
+  locateStartModal() {
+    return this.page.getByTestId('start-modal')
+  }
+
+  /**
+   * Check if the Asset Panel is shown.
+   */
+  isStartModalShown() {
+    return this.locateStartModal()
+      .isHidden()
+      .then(
+        (result) => !result,
+        () => false,
+      )
   }
 
   /** Create a project from the template at the given index. */