Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements, L2 primary names #336

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Misc improvements, L2 primary names #336

merged 9 commits into from
Nov 15, 2024

Conversation

gskril
Copy link
Member

@gskril gskril commented Oct 21, 2024

  • Update info and code examples for namehash/labelhash/dns encoding, remove separate page for namehash and add redirect
  • more to come, will update as i go

Should combine with name processing page, or break out more clearly
Copy link

cloudflare-workers-and-pages bot commented Oct 21, 2024

Deploying ens-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 047f9c1
Status: ✅  Deploy successful!
Preview URL: https://98d9f3e0.docs-bao.pages.dev
Branch Preview URL: https://ethglobal-sf-feedback.docs-bao.pages.dev

View logs

app/public/_redirects Outdated Show resolved Hide resolved
@ensdomains ensdomains deleted a comment from Nmhth17 Oct 31, 2024
@gskril gskril marked this pull request as ready for review November 15, 2024 07:40
@gskril gskril changed the title Address ETHGlobal SF feedback Misc improvements, L2 primary names Nov 15, 2024
Copy link
Member

@lucemans lucemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/resolvers/ccip-read.mdx Show resolved Hide resolved
@lucemans lucemans merged commit 34596e9 into master Nov 15, 2024
4 checks passed
@lucemans lucemans deleted the ethglobal-sf-feedback branch November 15, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants