Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Endurance chain support #383

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

blascokoa
Copy link

@blascokoa blascokoa commented Mar 21, 2023

Description

Added ACE the native coin from Endurance EVM Chain.

Reference to the test address.

https://explorer-endurance.fusionist.io/
Endurance, being an EVM Chain, adding it to Slip44 is not required, and following the last merge that implements convertEVMChainIdToCoinType added the ChainID to proceed with the correct conversion.

List of features added/changed

  • Added ACE on README.md
  • Added ACE on src/index.ts
  • Added ACE test case on src/tests/index.test.ts

NOTE: If you are adding new coin address support, please make sure to add a reference link to README so that reviewer can verify.

How much has the filesize increased?

  • Before: 416859
  • After: 416873
  • Difference: 14

How Has This Been Tested?

Run yarn test with zero issues.

Checklist:

  • My code follows the code style of this project.
  • My code implements all the required features.
  • I have specified correct coinTypes specified at Slip 44
  • I have provided the reference link to the specification I implemented.
  • I have provided enough explanation about how I provided the test address

@blascokoa blascokoa changed the title Ensdomains Add Endurance chain support Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant