Add BSC, MATIC, ARB1 all using chainId #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
convertEVMChainIdToCoinType
logic.Dependencies.
Once this change is merged, the following should happen in the order listed.
convertEVMChainIdToCoinType(chainId)
instead of coinType #318NOTE
The following chains are EVM compatible chains but they support multiple address formats.
We could either keep them out of scope, or add separate entities (AVAX, AVAXP, AVAXC, etc) for a single chain
NOTE 2
Some of layer 2s like zksync, starkware have their own address format so they are out of scope.