Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BSC, MATIC, ARB1 all using chainId #322

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Add BSC, MATIC, ARB1 all using chainId #322

merged 4 commits into from
Dec 15, 2021

Conversation

makoto
Copy link
Member

@makoto makoto commented Nov 27, 2021

Changes

  • Fix convertEVMChainIdToCoinType logic.
  • In addition to ARB1, add back MATIC and BSC using convertEVMChainIdToCoinType (not using SLIP44 cointype)

Dependencies.

Once this change is merged, the following should happen in the order listed.

NOTE

The following chains are EVM compatible chains but they support multiple address formats.

We could either keep them out of scope, or add separate entities (AVAX, AVAXP, AVAXC, etc) for a single chain

NOTE 2

Some of layer 2s like zksync, starkware have their own address format so they are out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants