Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.4.0 #81

Merged
merged 5 commits into from
Oct 21, 2024
Merged

V0.4.0 #81

merged 5 commits into from
Oct 21, 2024

Conversation

peterdesmet
Copy link
Member

No description provided.

@PietrH
Copy link
Collaborator

PietrH commented Oct 21, 2024

Ready for review?

  • Why did you remove authors.md?
  • I quite like having a changelog included, just like NEWS in case the repo ever gets moved, is referring to the releases page a common practise?

@PietrH
Copy link
Collaborator

PietrH commented Oct 21, 2024

I see you are still working on it. Let me know when you are ready for me to have a look at this.

@peterdesmet
Copy link
Member Author

Why did you remove authors.md?

Because that information is now better maintained in CITATION.cff. I don't think we need to refer to it from the website.

I quite like having a changelog included, just like NEWS in case the repo ever gets moved, is referring to the releases page a common practise?

I just wanted to maintain release info in one place, but you're right that we can maintain in CHANGELOG.md (as a running document) and copy paste to releases. Note however that this was not done for the alpha releases, so it's easy to forget. If you want, you can reinstate the CHANGELOG.md and add the alpha release info (bundled under a 0.4.0 release).

Ready for review

Copy link
Collaborator

@PietrH PietrH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintaining the changelog in one place is very practical. Thanks for getting this done so quickly! 👍

@peterdesmet peterdesmet merged commit 87728e4 into main Oct 21, 2024
4 checks passed
@peterdesmet peterdesmet deleted the v0.4.0 branch October 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants