Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONS introduces multiple labels, which is problematic #34

Open
matentzn opened this issue May 7, 2022 · 5 comments
Open

ONS introduces multiple labels, which is problematic #34

matentzn opened this issue May 7, 2022 · 5 comments

Comments

@matentzn
Copy link

matentzn commented May 7, 2022

ONS introduces a label on a FOODON term, "shrimp":

image

This is problematic for various reasons. Tools assume one canonical label per class. The only possible exception is labels in other languages, clearly distinguished by different language tags..

cc @ddooley

@ddooley
Copy link
Contributor

ddooley commented May 9, 2022

@FrancescoVit Do you need a hand addressing this one? 2ndary labels should be made into synonyms or alternate labels.

@FrancescoVit
Copy link
Member

@ddooley eventually, how to understand which of the two labels should be mutated to synonim or alternate? should an "editor preferred label" be used?

@ddooley
Copy link
Contributor

ddooley commented May 13, 2022

First, all this duplicate label stuff may be a result of merging updated FoodOn import files into ONS rather than the better way of keeping them as separate files referenced from within ons-edit.owl? It looks like you have the "shrimp as food source" FoodOn label from a few years ago, and then a more recent simplified "shrimp" label. This whole problem I think would be solved by using the OWL import system 100% for reference to all terms not defined by ONS. I can help revise your setup to accomplish that.

Right now the latest "shrimp" term is in this import file:
image
while the "shrimp as food source" is sitting permanently in your ons-edit.owl file. We need to get that out of ons-edit.owl And it would be good to have a better file name and URL specified in the "shrimp" term's import file.

@ddooley
Copy link
Contributor

ddooley commented May 13, 2022

By the way, our latest policy around what to associate food references like "shrimp" is here: FoodOntology/foodon#133 - see the very last diagram. In other words, what should we reference when someone mentions "shrimp". (Not mentioned in that writeup is a term like shrimp doesn't have a direct taxonomic equiivalent because humans have alot of crossover in referencing prawns as shrimp and visa versa.)

@ddooley
Copy link
Contributor

ddooley commented May 23, 2024

This should be resolved now, so can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants